[libvirt PATCH 07/26] meson: Use built-in pcap detection

Andrea Bolognani abologna at redhat.com
Tue Jun 1 08:37:38 UTC 2021


Meson already knows how to look for pcap using pkg-config
first, and falling back to pcap-config if that didn't work.

https://mesonbuild.com/Dependencies.html#pcap

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 meson.build | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/meson.build b/meson.build
index 7f6756abca..81f8caae06 100644
--- a/meson.build
+++ b/meson.build
@@ -978,19 +978,7 @@ endif
 
 libpcap_version = '1.5.0'
 if not get_option('libpcap').disabled()
-  libpcap_dep = dependency('libpcap', version: '>=' + libpcap_version, required: false)
-
-  if not libpcap_dep.found()
-    pcap_config_prog = find_program('pcap-config', required: get_option('libpcap'))
-    if pcap_config_prog.found()
-      pcap_args = run_command(pcap_config_prog, '--cflags').stdout().strip().split()
-      pcap_libs = run_command(pcap_config_prog, '--libs').stdout().strip().split()
-      libpcap_dep = declare_dependency(
-        compile_args: pcap_args,
-        link_args: pcap_libs,
-      )
-    endif
-  endif
+  libpcap_dep = dependency('pcap', version: '>=' + libpcap_version, required: get_option('libpcap'))
 else
   libpcap_dep = dependency('', required: false)
 endif
-- 
2.31.1




More information about the libvir-list mailing list