[libvirt PATCH 16/26] meson: Fix firewalld check

Andrea Bolognani abologna at redhat.com
Tue Jun 1 08:37:47 UTC 2021


firewalld is Linux-only, so it should be disabled by default
everywhere else and attempts to explicitly enable firewalld
support on non-Linux targets should result in an error.

Signed-off-by: Andrea Bolognani <abologna at redhat.com>
---
 meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index faccbd750c..0b2e3e062e 100644
--- a/meson.build
+++ b/meson.build
@@ -1342,8 +1342,11 @@ endif
 if not get_option('firewalld').disabled()
   firewalld_enable = true
 
-  if host_machine.system() == 'freebsd'
+  if host_machine.system() != 'linux'
     firewalld_enable = false
+    if get_option('firewalld').enabled()
+      error('firewalld support can only be enabled on Linux')
+    endif
   endif
 
   if firewalld_enable
-- 
2.31.1




More information about the libvir-list mailing list