[libvirt PATCH 26/26] meson: Don't include warning flags in summary

Pavel Hrdina phrdina at redhat.com
Tue Jun 1 09:39:19 UTC 2021


On Tue, Jun 01, 2021 at 10:37:57AM +0200, Andrea Bolognani wrote:
> The list takes up half a screen on my machine and it doesn't
> seem useful enough for that to be warranted, especially when it
> results in other, arguably more relevant parts of the summary
> being pushed off-screen.

It might be useful in some cases when users report that libvirt fails to
compile and they will provide meson configure output but it is possible
to get the list of flags by other means as well so I agree with you that
we can drop it from summary. I would way for others to express their
opinion as well.

Pavel

> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  meson.build | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index a5f6ed6f9f..28c953067c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2321,11 +2321,6 @@ docs_summary = {
>  }
>  summary(docs_summary, section: 'Documentation', bool_yn: true)
>  
> -build_summary = {
> -  'Warning Flags': supported_cc_flags,
> -}
> -summary(build_summary, section: 'Build', bool_yn: true, list_sep: ' ')
> -
>  target_summary = {
>    'OS': host_machine.system(),
>    'Init script': init_script,
> -- 
> 2.31.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210601/1cdc5a3c/attachment-0001.sig>


More information about the libvir-list mailing list