[libvirt PATCH] docs: introduce stubs for new libvirt Go packages

Andrea Bolognani abologna at redhat.com
Tue Jun 1 09:54:08 UTC 2021


On Tue, May 25, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote:
> The corresponding repos exist
>
>   https://gitlab.com/libvirt/libvirt-go-module
>   https://gitlab.com/libvirt/libvirt-go-xml-module
>
> but I'm leaving them empty until we've completed this release, then
> I'll populate with content matching 7.4.0, minus the existing tags.
> This change should also wait until after the release.

Thanks for creating the new repos! Please let's make sure all open
discussion threads on

  https://gitlab.com/libvirt/libvirt-go/-/issues/9

are resolved before pushing anything to them.

> +foreach name : docs_go_files
> +  rst_file = '@0 at .rst'.format(name)
> +
> +  html_xslt_gen += {
> +    'name': name,
> +    'file': docs_rst2html_gen.process(rst_file),
> +    'source': 'docs/go' / rst_file,

I believe this should be

  'source': 'docs' / 'go' / rst_file,

Everything else looks good, but we should also add a note to the
existing docs/libvirt-go(-xml).rst telling users that those Go
package identifiers are deprecated and they should use the new ones
instead.

-- 
Andrea Bolognani / Red Hat / Virtualization





More information about the libvir-list mailing list