[libvirt PATCH 00/26] meson: Various fixes and improvements

Andrea Bolognani abologna at redhat.com
Tue Jun 1 12:55:04 UTC 2021


On Tue, Jun 01, 2021 at 11:41:37AM +0200, Pavel Hrdina wrote:
> On Tue, Jun 01, 2021 at 10:37:31AM +0200, Andrea Bolognani wrote:
> > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/312508056
> >
> > Andrea Bolognani (26):
> >   spec: Be explicit about more features
> >   meson: Whitespace tweaks
> >   meson: Don't use 'required: true'
> >   meson: Drop curl workaround
> >   meson: Drop netinet workaround
> >   meson: Use get_pkgconfig_variable('cflags')
> >   meson: Use built-in pcap detection
> >   meson: Make libm a required dependency
> >   meson: Drop numactl_version
> >   meson: Fix vstorage detection
> >   meson: Fix sanlock detection
> >   meson: Rewrite polkit check
> >   meson: Tweak XDR check
> >   meson: Fix disabling netcf
> >   meson: Rewrite firewalld check
> >   meson: Fix firewalld check
> >   meson: Rewrite libacl check
> >   meson: Use dependency() when possible
> >   meson: Rewrite apparmor_profiles check
> >   meson: Turn apparmor_profiles into a feature
> >   meson: Switch to autodetection for apparmor_profiles
> >   meson: Switch to autodetection for driver_remote
> >   meson: Switch to autodetection for driver_test
> >   meson: Style tweaks
>
> For the above patches with the issues fixed.
>
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>

Thanks, I've pushed these now.

> >   meson: Reorganize summary
>
> I would post the changes as separate series so it's not blocking this
> one.

Fair point. I actually have more changes lined up that would alter
the summary further, so I might end up rolling the two together.

> >   meson: Don't include warning flags in summary
>
> Once we have some other opinions as well.
>
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>

I'll rework this so that it's stand-alone and repost it.

Thanks again!

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list