[libvirt] [PATCH 2/2] virsh: Add coredump format completion to dump command

Michal Prívozník mprivozn at redhat.com
Mon Jun 7 14:32:49 UTC 2021


On 6/7/21 5:14 AM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  tools/virsh-completer-domain.c | 19 +++++++++++++++++++
>  tools/virsh-completer-domain.h |  5 +++++
>  tools/virsh-domain.c           |  2 ++
>  3 files changed, 26 insertions(+)
> 

> diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h
> index ef242d0c68..f548f7ba9e 100644
> --- a/tools/virsh-completer-domain.h
> +++ b/tools/virsh-completer-domain.h
> @@ -122,3 +122,8 @@ char ** virshKeycodeNameCompleter(vshControl *ctl,
>  char ** virshDomainFSMountpointsCompleter(vshControl *ctl,
>                                            const vshCmd *cmd,
>                                            unsigned int flags);
> +
> +char **
> +virshDomainCoreDumpFormatCompleter(vshControl *ctl G_GNUC_UNUSED,
> +                                   const vshCmd *cmd G_GNUC_UNUSED,
> +                                   unsigned int flags);

We don't like marking arguments as unused in header files. That's left
for corresponding .c file to do.

Michal




More information about the libvir-list mailing list