[PATCH v2 10/10] vircaps2xmltest: Introduce HMAT test case

[Martin Kletzander]

On Thu, Jun 10, 2021 at 03:57:19PM +0200, Michal Privoznik wrote:
>This test was generated on a guest with the following NUMA
>configuration:
>
>    <numa>
>      <cell id='0' cpus='0-23' memory='4194304' unit='KiB' discard='yes'>
>        <cache level='1' associativity='direct' policy='writeback'>
>          <size value='10' unit='KiB'/>
>          <line value='8' unit='B'/>
>        </cache>
>        <cache level='2' associativity='full' policy='writethrough'>
>          <size value='128' unit='KiB'/>
>          <line value='16' unit='B'/>
>        </cache>
>      </cell>
>      <cell id='1' memory='2097152' unit='KiB'>
>        <cache level='1' associativity='direct' policy='writeback'>
>          <size value='10' unit='KiB'/>
>          <line value='8' unit='B'/>
>        </cache>
>      </cell>
>      <interconnects>
>        <latency initiator='0' target='0' type='access' value='5'/>
>        <latency initiator='0' target='0' type='read' value='6'/>
>        <latency initiator='0' target='0' type='write' value='7'/>
>        <latency initiator='0' target='1' type='access' value='10'/>
>        <latency initiator='0' target='1' type='read' value='11'/>
>        <latency initiator='0' target='1' type='write' value='12'/>
>        <bandwidth initiator='0' target='0' type='access' value='204800' unit='KiB'/>
>        <bandwidth initiator='0' target='0' type='read' value='205824' unit='KiB'/>
>        <bandwidth initiator='0' target='0' type='write' value='206848' unit='KiB'/>
>        <bandwidth initiator='0' target='0' cache='1' type='access' value='208896' unit='KiB'/>
>        <bandwidth initiator='0' target='0' cache='1' type='read' value='209920' unit='KiB'/>
>        <bandwidth initiator='0' target='0' cache='1' type='write' value='210944' unit='KiB'/>
>        <bandwidth initiator='0' target='1' type='access' value='102400' unit='KiB'/>
>        <bandwidth initiator='0' target='1' type='read' value='103424' unit='KiB'/>
>        <bandwidth initiator='0' target='1' type='write' value='104448' unit='KiB'/>
>        <bandwidth initiator='0' target='1' cache='1' type='access' value='105472' unit='KiB'/>
>        <bandwidth initiator='0' target='1' cache='1' type='read' value='106496' unit='KiB'/>
>        <bandwidth initiator='0' target='1' cache='1' type='write' value='107520' unit='KiB'/>
>      </interconnects>
>    </numa>
>
>The sysfs content was also copied over from the VM but only those
>files which are accessed in the test are stored in the repo.
>

Just out of curiosity, did you use your access check for that?

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

[...]

>
>diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
>index 552d639119..be55f26e19 100644
>--- a/build-aux/syntax-check.mk
>+++ b/build-aux/syntax-check.mk
>@@ -1835,7 +1835,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \
>   ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$
>
> exclude_file_name_regexp--sc_prohibit_empty_first_line = \
>-  ^(src/esx/README|tests/(vmwarever|virhostcpu)data/.*)$$
>+  ^(src/esx/README|tests/(vmwarever|virhostcpu|vircaps2xml)data/.*)$$
>

This one bothered me a little bit, but not because of this patch.  I'll send a
patch to make it hopefully nicer =)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210614/3e271659/attachment-0001.sig>