[libvirt PATCH] qemu_hotplug: Report VIR_ERR_DEVICE_MISSING when device is not found

Peter Krempa pkrempa at redhat.com
Tue Jun 15 08:28:26 UTC 2021


On Mon, Jun 14, 2021 at 11:18:37 +0100, Lee Yarwood wrote:
> 126db34a81bc9f9f9710408f88cceaa1e34bbbd7 had previously switched various
> flows over to this from VIR_ERR_OPERATION_FAILED.
> 
> This change simply does the same for qemuDomainDetachPrepDisk,
> qemuDomainDetachPrepInput and qemuDomainDetachPrepVsock to allow
> management apps to centralise their error handling on just
> VIR_ERR_DEVICE_MISSING for missing devices during a detach.

The patch looks good but you didn't include your certification of
agreement with the developer certificate of origin (Sign-off).

I can add it without the need to re-send if you agree and reply with the
sign-off.




More information about the libvir-list mailing list