[PATCH] test_driver: Implement virDomainGetSecurityLabelList

Martin Kletzander mkletzan at redhat.com
Tue Jun 15 08:08:24 UTC 2021


On Mon, Jun 14, 2021 at 09:12:57PM +0800, Luke Yue wrote:
>Signed-off-by: Luke Yue <lukedyue at gmail.com>
>---
> src/test/test_driver.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>

This patch looks fine, but it would be good to have tests for it also.
The good thing is that thanks to the fact that this is a test driver API
the check can be done using just virsh, no need to write tests and mock
syscalls.  The previous patches added at least some checks, because it
was already in some other test codepath, but this (and later ones as
well) are going to need to have some new ones added.

Thanks,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210615/09e89288/attachment-0001.sig>


More information about the libvir-list mailing list