[PATCH] virFindFileInPath: Don't pass NULL to g_canonicalize_filename()

Michal Privoznik mprivozn at redhat.com
Tue Jun 15 16:05:49 UTC 2021


If given file is not found in $PATH then g_find_program_in_path()
returns NULL. However, g_canonicalize_filename() does not accept
NULL as input.

Fixes: 65c2901906b5e2d707f9184ff3719a5375bab427
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/util/virfile.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index c302202573..4f98b011be 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -1667,6 +1667,8 @@ virFindFileInPath(const char *file)
         return NULL;
 
     path = g_find_program_in_path(file);
+    if (!path)
+        return NULL;
 
     /* Workaround for a bug in g_find_program_in_path() not returning absolute
      * path as documented.  This has been fixed in
-- 
2.31.1




More information about the libvir-list mailing list