[libvirt PATCH 2/3] qemu: wait more for virtiofsd to exit

[Michal Prívozník]

On 6/18/21 1:45 PM, Ján Tomko wrote:
> In some cases, such as doing intense I/O on slow filesystems,
> it can take virtiofsd as long as 42 seconds to exit.
> 
> Add a delay of extra 45 seconds before we forcefully kill it.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1940276

This is inaccessible :-( We should look into making it accessible.

> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/qemu/qemu_virtiofs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c
> index edaedf0304..3f99f0caa4 100644
> --- a/src/qemu/qemu_virtiofs.c
> +++ b/src/qemu/qemu_virtiofs.c
> @@ -281,7 +281,7 @@ qemuVirtioFSStop(virQEMUDriver *driver G_GNUC_UNUSED,
>      if (!(pidfile = qemuVirtioFSCreatePidFilename(vm, fs->info.alias)))
>          goto cleanup;
>  

Please put a comment here that the wait is 30 + 15 seconds. Otherwise 30
is misleading.

> -    if (virPidFileForceCleanupPath(pidfile) < 0) {
> +    if (virPidFileForceCleanupPathDelay(pidfile, 30) < 0) {
>          VIR_WARN("Unable to kill virtiofsd process");
>      } else {
>          if (QEMU_DOMAIN_FS_PRIVATE(fs)->vhostuser_fs_sock)
> 

Michal