[PATCHv2] ch_domain: Add handler for virDomainDeviceDefValidateCallback
Peter Krempa
pkrempa at redhat.com
Mon Jun 21 07:33:44 UTC 2021
On Fri, Jun 18, 2021 at 14:25:59 -0700, William Douglas wrote:
> Instead of trying to match devices passed in based on the monitor
> detecting the number of devices that were used in the domain
> definition, use the deviceValidateCallback to evaluate if
> unsupported devices are used.
>
> This allows the compiler to detect when new device types are added
> that need to be checked.
>
> Signed-off-by: William Douglas <william.douglas at intel.com>
> ---
> The only change from the previous version was to switch to use the XML
> validation callback based on the great explanations from Michal and Peter.
> ---
> src/ch/ch_domain.c | 120 +++++++++++++++++++++++++++++++++++++++++++
> src/ch/ch_monitor.c | 122 --------------------------------------------
> 2 files changed, 120 insertions(+), 122 deletions(-)
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
I'll follow up with a cleanup simplifying the code a bit.
More information about the libvir-list
mailing list