[libvirt PATCH] virresctrl: fix starting VMs with cputune.memorytune specified
Jano Tomko
jtomko at redhat.com
Mon Jun 21 11:14:09 UTC 2021
On 6/21/21 1:08 PM, Pavel Hrdina wrote:
> When removing check for return value of VIR_EXPAND_N this place was
> incorrectly modified causing failure to start a VM with cputune
> memorytune configured with useless error message:
>
> error: Failed to start domain 'vm1'
> error: An error occurred, but the cause is unknown
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1973094
> Fixes: 7d2fd6ef0163a939adb7ce0f0fad3b7654c340de
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
> src/util/virresctrl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
> index a03113d4d6..35e92022db 100644
> --- a/src/util/virresctrl.c
> +++ b/src/util/virresctrl.c
> @@ -1437,7 +1437,6 @@ virResctrlAllocParseProcessMemoryBandwidth(virResctrlInfo *resctrl,
> if (alloc->mem_bw->nbandwidths <= id) {
> VIR_EXPAND_N(alloc->mem_bw->bandwidths, alloc->mem_bw->nbandwidths,
> id - alloc->mem_bw->nbandwidths + 1);
> - return -1;
> }
> if (!alloc->mem_bw->bandwidths[id])
> alloc->mem_bw->bandwidths[id] = g_new0(unsigned int, 1);
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
More information about the libvir-list
mailing list