[libvirt PATCH 6/7] nodedev: Implement virNodeDeviceIsPersistent()/IsActive()

Boris Fiuczynski fiuczy at linux.ibm.com
Tue Jun 22 15:41:25 UTC 2021


On 6/22/21 5:08 PM, Jonathon Jongsma wrote:
> On Tue, Jun 22, 2021 at 10:03 AM Boris Fiuczynski <fiuczy at linux.ibm.com> wrote:
>>
>> On 6/22/21 4:33 PM, Jonathon Jongsma wrote:
>>> So it appears that there is a bug where an mdev is still marked as
>>> autostart even after it's undefined. Was there anything else you were
>>> trying to demonstrate?
>>>
>>> Jonathon
>>
>> Don't you need to resync with mdevctl on nodedev-info?
>> If you would resync and fail to find the definition for the mdev your
>> bugfix would be to set the autostart to "no". The shortcut would be to
>> set autostart to "no" when undefine is called but that would leave out
>> direct usage of mdectl.
> 
> Yes, it appears that there's a bug in my patch that needs to be fixed.
> 
> But your email said
> 
>> "The default "yes" seems to be not really a good choice even for mdevs.
> 
> That makes it sound like you think there's something more
> fundamentally wrong than just a simple bug where a value didn't get
> updated properly.
> 
> Jonathon
> 

Is the current code resyncing with mdevctl on nodedev-info calls 
persisted and autostart? Is using mdevctl directly something libvirt 
needs to worry about with regard to data consistency?

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





More information about the libvir-list mailing list