[PATCH V3 1/2] Apparmor: Add profile for virtqemud

[Christian Boltz]

Hello,

[please CC me in replies]

Your updated patches still look good, I just noticed something that is 
probably minor nitpicking:

Am Donnerstag, 24. Juni 2021, 22:48:58 CEST schrieb Jim Fehlig:
[...]
> +  signal (send) set=("kill", "term") peer=unconfined,
[...]
> +  signal (send) set=("term") peer=libvirtd//qemu_bridge_helper, 

The quotes around the signal names are superfluous. You can simply use 
    set=(kill, term)
    set=(term)

Actually the parenthesis are optional if there's only a single signal 
mentioned, so you could also use
    set=term
(keeping the parenthesis for consistency with other rules is also fine)


There are several signal rules with superfluous quotes in this patch, 
and also one in the 2/2 patch.

(There's no need to re-send the patch for such a minor change IMHO.)


Regards,

Christian Boltz
-- 
I'm root - if you see me laughing you better have a backup!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210625/72d4027d/attachment-0001.sig>