[libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests

Michal Prívozník mprivozn at redhat.com
Wed Jun 30 07:59:29 UTC 2021


On 6/25/21 4:27 PM, Andrea Bolognani wrote:
> The current default is unfortunately broken, and the user has to
> manually step in and provide the version number explicitly for the
> TPM device to work at all.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1970310
> 
> Andrea Bolognani (5):
>   docs: Fix information for default TPM version
>   tests: Add aarch64-tpm test to qemuxml2xml
>   qemu: Default to TPM 2.0 for ARM virt guests
>   tests: Test the defaults for TPM on ARM virt guests
>   qemu: Reject TPM 1.2 for ARM virt guests
> 
>  docs/formatdomain.rst                         |  9 ++++--
>  src/qemu/qemu_domain.c                        |  3 +-
>  src/qemu/qemu_validate.c                      |  6 ++++
>  .../aarch64-tpm-wrong-model.err               |  1 +
>  ...64-tpm.xml => aarch64-tpm-wrong-model.xml} |  2 +-
>  tests/qemuxml2argvdata/aarch64-tpm.xml        |  4 +--
>  tests/qemuxml2argvtest.c                      |  1 +
>  .../aarch64-tpm.aarch64-latest.xml            | 29 +++++++++++++++++++
>  tests/qemuxml2xmltest.c                       |  1 +
>  9 files changed, 49 insertions(+), 7 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/aarch64-tpm-wrong-model.err
>  copy tests/qemuxml2argvdata/{aarch64-tpm.xml => aarch64-tpm-wrong-model.xml} (88%)
>  create mode 100644 tests/qemuxml2xmloutdata/aarch64-tpm.aarch64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list