[PATCH] ui: Mark the '-no-quit' option as deprecated

Thomas Huth thuth at redhat.com
Wed Jun 30 10:16:18 UTC 2021


On 30/06/2021 12.01, Peter Maydell wrote:
> On Wed, 30 Jun 2021 at 10:22, Thomas Huth <thuth at redhat.com> wrote:
>>
>> It's just a cumbersome wrapper around the -display ...,window_close=off
>> parameter, so we should rather tell our users to use that instead.
> 
> This is an interesting definition of "cumbersome" -- personally
> I would say the long -display option is the cumbersome one :-)

The cumbersome was rather meant from a code / maintenance side of view. But 
I think the naming of this parameter is also quite misleading. It really 
just blocks the closing button of the window, you can still quit QEMU by 
other means (e.g. with the "Quit" menu item in the GTK menu or by shutting 
down the guest), so the "window_close=off" wording is certainly more 
understandable.

... and by the way, I think the documentation in qemu-options.hx is 
inaccurate, too, it only talks about SDL, but it seems like this option is 
also available with GTK. So this -no-quit option really seems like old cruft 
to me which we should try to get rid of...

  Thomas




More information about the libvir-list mailing list