[PATCH v2 19/31] qapi/qom: QAPIfy object-add
Paolo Bonzini
pbonzini at redhat.com
Mon Mar 1 12:03:15 UTC 2021
On 01/03/21 12:54, Kevin Wolf wrote:
>> Please add a check in object_property_add_child that the id is well formed
>> (using the id_wellformed function). This is pre-existing, but it becomes a
>> regression for -object later in the series.
> Are the conditions for internally called object_property_add_child()
> actually the same as for IDs specified by the user? For example, I seem
> to remember some array-ish properties with [] in their name which aren't
> allowed by id_wellformed().
Yes, you are right.
> The obvious place to affect only the external interfaces would be
> user_creatable_add_type().
Makes sense, thanks.
Paolo
More information about the libvir-list
mailing list