[PATCH 04/16] virDevMapperGetTargetsImpl: Use virStrcpy instead of virStrncpy

Peter Krempa pkrempa at redhat.com
Tue Mar 2 14:49:21 UTC 2021


virStrncpy was called with -1 for lenght of the copied source which is
equivalent to virStrcpy.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/util/virdevmapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c
index d97334bf67..fcb11e954f 100644
--- a/src/util/virdevmapper.c
+++ b/src/util/virdevmapper.c
@@ -240,7 +240,7 @@ virDevMapperGetTargetsImpl(int controlFD,
     if (!(sanitizedPath = virDMSanitizepath(path)))
         return 0;

-    if (virStrncpy(dm.name, sanitizedPath, -1, DM_TABLE_DEPS) < 0) {
+    if (virStrcpy(dm.name, sanitizedPath, DM_TABLE_DEPS) < 0) {
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                        _("Resolved device mapper name too long"));
         return -1;
-- 
2.29.2




More information about the libvir-list mailing list