[PATCH 5/6] qemuProcessReportLogError: Don't mark "%s: %s" as translatable

Peter Krempa pkrempa at redhat.com
Tue Mar 2 15:21:07 UTC 2021


The function is constructing an error message from a prefix and the
contents of the qemu log file. Marking just two string modifiers as
translatable is pointless and will certainly confuse translators.

Remove the marking and add a comment which bypasses the
sc_libvirt_unmarked_diagnostics check.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_process.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 55649286ae..aa547686c1 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2149,7 +2149,8 @@ qemuProcessReportLogError(qemuDomainLogContextPtr logCtxt,
     if (virStringIsEmpty(logmsg))
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msgprefix);
     else
-        virReportError(VIR_ERR_INTERNAL_ERROR, _("%s: %s"), msgprefix, logmsg);
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s: %s", /* _( silence sc_libvirt_unmarked_diagnostics */
+                       msgprefix, logmsg);

     return 0;
 }
-- 
2.29.2




More information about the libvir-list mailing list