[PATCH 1/6] virPipeImpl: Don't overwrite error

Peter Krempa pkrempa at redhat.com
Tue Mar 2 16:12:03 UTC 2021


If WITH_PIPE2 is not defined we attempt to set the pipe to nonblocking
operation after they are created. We errorneously rewrote the existing
error message on failure to do so or even reported an error if quiet
mode was requested.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/util/virutil.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/util/virutil.c b/src/util/virutil.c
index a0cd0f1bcd..0f3cf98613 100644
--- a/src/util/virutil.c
+++ b/src/util/virutil.c
@@ -1924,8 +1924,6 @@ virPipeImpl(int fds[2], bool nonblock, bool errreport)
             if (errreport)
                 virReportSystemError(errno, "%s",
                                      _("Unable to set pipes to non-blocking"));
-            virReportSystemError(errno, "%s",
-                                 _("Unable to create pipes"));
             VIR_FORCE_CLOSE(fds[0]);
             VIR_FORCE_CLOSE(fds[1]);
             return -1;
-- 
2.29.2




More information about the libvir-list mailing list