[libvirt PATCH 3/3] vircgroup: drop unused function virCgroupSetupCpuShares

Pavel Hrdina phrdina at redhat.com
Wed Mar 3 13:35:22 UTC 2021


Previous commit removed all usage of this function so we can remove it.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/libvirt_private.syms |  1 -
 src/util/vircgroup.c     | 20 --------------------
 src/util/vircgroup.h     |  2 --
 3 files changed, 23 deletions(-)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 2a3bbdc577..3e7de7744e 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1934,7 +1934,6 @@ virCgroupSetupBlkioDeviceWriteBps;
 virCgroupSetupBlkioDeviceWriteIops;
 virCgroupSetupCpuPeriodQuota;
 virCgroupSetupCpusetCpus;
-virCgroupSetupCpuShares;
 virCgroupSupportsCpuBW;
 virCgroupTerminateMachine;
 
diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c
index abc06b8cb0..5b6097c335 100644
--- a/src/util/vircgroup.c
+++ b/src/util/vircgroup.c
@@ -3899,26 +3899,6 @@ virCgroupSetupCpusetCpus(virCgroupPtr cgroup, virBitmapPtr cpumask)
 }
 
 
-/* Per commit 97814d8ab3, the Linux kernel can consider a 'shares'
- * value of '0' and '1' as 2, and any value larger than a maximum
- * is reduced to maximum.
- *
- * The 'realValue' pointer holds the actual 'shares' value set by
- * the kernel if the function returned success. */
-int
-virCgroupSetupCpuShares(virCgroupPtr cgroup, unsigned long long shares,
-                        unsigned long long *realValue)
-{
-    if (virCgroupSetCpuShares(cgroup, shares) < 0)
-        return -1;
-
-    if (virCgroupGetCpuShares(cgroup, realValue) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 int
 virCgroupSetupCpuPeriodQuota(virCgroupPtr cgroup,
                              unsigned long long period,
diff --git a/src/util/vircgroup.h b/src/util/vircgroup.h
index 7d9172d664..4e6911f34c 100644
--- a/src/util/vircgroup.h
+++ b/src/util/vircgroup.h
@@ -227,8 +227,6 @@ virCgroupGetDomainTotalCpuStats(virCgroupPtr group,
 
 int virCgroupSetCpuShares(virCgroupPtr group, unsigned long long shares);
 int virCgroupGetCpuShares(virCgroupPtr group, unsigned long long *shares);
-int virCgroupSetupCpuShares(virCgroupPtr cgroup, unsigned long long shares,
-                            unsigned long long *realValue);
 
 #define VIR_CGROUP_CPU_SHARES_MIN 2LL
 #define VIR_CGROUP_CPU_SHARES_MAX 262144LL
-- 
2.29.2




More information about the libvir-list mailing list