[libvirt PATCH 01/18] config: cleanup some typos / baggage wrt compiler checks

Daniel P. Berrangé berrange at redhat.com
Wed Mar 3 18:18:17 UTC 2021


We had a copy and paste mistake from code we mirrored from QEMU, as well
as failing to remove an earlier redundant check.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 config.h | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/config.h b/config.h
index 2ee7f7bff6..ca6720f37d 100644
--- a/config.h
+++ b/config.h
@@ -25,10 +25,6 @@
 # define _FORTIFY_SOURCE 2
 #endif
 
-#ifndef __GNUC__
-# error "Libvirt requires GCC >= 4.8, or Clang"
-#endif
-
 /*
  * Define __GNUC_PREREQ to a sane default if it isn't yet defined.
  * This is done here so that it's included as early as possible;
@@ -41,16 +37,16 @@
 #if defined(__clang_major__) && defined(__clang_minor__)
 # ifdef __apple_build_version__
 #  if __clang_major__ < 5 || (__clang_major__ == 5 && __clang_minor__ < 1)
-#   error You need at least XCode Clang v5.1 to compile QEMU
+#   error You need at least XCode Clang v5.1 to compile libvirt
 #  endif
 # else
 #  if __clang_major__ < 3 || (__clang_major__ == 3 && __clang_minor__ < 4)
-#   error You need at least Clang v3.4 to compile QEMU
+#   error You need at least Clang v3.4 to compile libvirt
 #  endif
 # endif
 #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
 # if __GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 8)
-#  error You need at least GCC v4.8 to compile QEMU
+#  error You need at least GCC v4.8 to compile libvirt
 # endif
 #else
 # error You either need at least GCC 4.8 or Clang 3.4 or XCode Clang 5.1 to compile libvirt
-- 
2.29.2




More information about the libvir-list mailing list