[PATCH] virBufferAdd: Ensure that the buffer is initialized also when len == 0

[Ján Tomko]

On a Thursday in 2021, Peter Krempa wrote:
>There's an optimization in virBufferAdd which returns early when the
>length of the added string is 0 (given that auto-indent is disabled).
>
>The optimization causes inconsistent behaviour between these two cases:
>
> virBufferAdd(buf, "", 0);  // this doesn't initialize the buffer
>
>and
>
> virBufferAdd(buf, "", -1); //this initializes the buffer
>
>Since using an empty string is used to prime the buffer to an empty
>string it can be confusing. Remove the optimization.
>
>This fixes such a wrong initialization done in x86FeatureNames.
>
>Note that our code in many places expects that if no virBuffer APIs are
>used on a buffer object, then NULL should be retured, so we can't always
>prime the buffer to an empty string.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210304/12da719e/attachment-0001.sig>