[PATCH v6 0/5] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate

[Hao Wang]

Great thanks for your reviewing!
I will update 5/5 and possibly 4/5 according to expected more suggestion in the next version.

BR,
Hao

On 2021/3/3 19:31, Michal Privoznik wrote:
> On 2/26/21 9:35 AM, Hao Wang wrote:
>>
>> Hao Wang (5):
>>    migration/dirtyrate: Introduce virDomainStartDirtyRateCalc API
>>    migration/dirtyrate: Implement qemuDomainStartDirtyRateCalc
>>    migration/dirtyrate: Introduce domdirtyrate-calc virsh api
>>    migration/dirtyrate: Implement qemuMonitorQueryDirtyRate
>>    migration/dirtyrate: Introduce command 'virsh domstats --dirtyrate'
>>
>>   docs/manpages/virsh.rst          |  33 ++++++++-
>>   include/libvirt/libvirt-domain.h |   5 ++
>>   src/driver-hypervisor.h          |   6 ++
>>   src/libvirt-domain.c             |  57 +++++++++++++++
>>   src/libvirt_public.syms          |   5 ++
>>   src/qemu/qemu_driver.c           | 115 +++++++++++++++++++++++++++++++
>>   src/qemu/qemu_monitor.c          |  24 +++++++
>>   src/qemu/qemu_monitor.h          |  18 +++++
>>   src/qemu/qemu_monitor_json.c     |  88 +++++++++++++++++++++++
>>   src/qemu/qemu_monitor_json.h     |   8 +++
>>   src/remote/remote_driver.c       |   1 +
>>   src/remote/remote_protocol.x     |  14 +++-
>>   src/remote_protocol-structs      |   6 ++
>>   tools/virsh-domain-monitor.c     |   7 ++
>>   tools/virsh-domain.c             |  63 +++++++++++++++++
>>   15 files changed, 447 insertions(+), 3 deletions(-)
>>
> 
> To patches 1-4:
> 
> Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
> 
> The last one 5/5 should be split. And I'd wait for others to give opinion on the enum vs string representation of calc_status. If we go with enum, then I think _qemuMonitorDirtyRateInfo struct in 4/5 should be updated to reflect this change.
> 
> We are almost there!
> 
> Michal
> 
> .