[PATCH] meson: tools: depend on keycode generated sources

Ján Tomko jtomko at redhat.com
Fri Mar 5 12:43:15 UTC 2021


On a Friday in 2021, Andrea Bolognani wrote:
>On Thu, 2021-03-04 at 17:47 +0100, Ján Tomko wrote:
>> On a Wednesday in 2021, Roman Bogorodskiy wrote:
>> > +keycode_dep = declare_dependency(sources: keycode_gen_sources)
>>
>> Please format this as:
>>
>> keycode_dep = declare_dependency(
>>    sources: keycode_gen_sources
>> )
>>
>> to match the prevailing style.
>
>Small correction: it should be
>
>  keycode_dep = declare_dependency(
>    sources: keycode_gen_sources,
>  )
>
>Note the additional comma, which allows us to have cleaner diffs when
>making further changes, and the indentation being only two spaces
>instead of three.

The three spaces come from your MUA misquoting me. I see two spaces in
my version of the e-mail, as well as the list archive:
https://listman.redhat.com/archives/libvir-list/2021-March/msg00252.html

(Not that my MUA is any better in that regard - the indentation in my
quoting of Roman's patch is wrong too)

Jano

>
>-- 
>Andrea Bolognani / Red Hat / Virtualization
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210305/b880f996/attachment-0001.sig>


More information about the libvir-list mailing list