[PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime and cache size

[Paolo Bonzini]

On 11/03/21 19:33, Daniel P. Berrangé wrote:
> On Thu, Mar 11, 2021 at 07:18:54PM +0100, Paolo Bonzini wrote:
>> On 11/03/21 12:54, Dr. David Alan Gilbert wrote:
>>> * Daniel P. Berrangé (berrange at redhat.com) wrote:
>>>> The generic 'migrate_set_parameters' command handle all types of param.
>>>>
>>>> Only the QMP commands were documented in the deprecations page, but the
>>>> rationale for deprecating applies equally to HMP, and the replacements
>>>> exist. Furthermore the HMP commands are just shims to the QMP commands,
>>>> so removing the latter breaks the former unless they get re-implemented.
>>>>
>>>> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>>>
>>> Yes OK; ouch that's going to break my 7 years of instinctive
>>> 'migrate_set_speed 10G' typing, but it's probably the right thing to do.
>>
>> migrate_set_speed should remain if it is not changed to have a sane default.
> 
> Define sane ?   The default is 1 Gib/s since:
> 
>    commit 7590a2ae091fde8bb72d5df93977ab9707e23242
>    Author: Laurent Vivier <lvivier at redhat.com>
>    Date:   Mon Sep 21 16:49:57 2020 +0200
> 
>      migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)

Oh, I missed that!  I was still thinking of the old 32 MiB/s value.

Paolo