[PATCH 3/6] syntax-check: Fix and rename virSecurity rule

Ján Tomko jtomko at redhat.com
Fri Mar 12 15:42:06 UTC 2021


On a Thursday in 2021, Michal Privoznik wrote:
>The aim of virSecurity rule is to discourage from using plain
>virSecurityManager*() APIs within QEMU driver in favor of their
>qemuSecurity*() counterparts. The reason is simple: namespaces;
>virSecurityManager*() needs additional
>virSecurityManagerTransactionCommit() call to enter given
>namespace and do its work from there. And that's exactly what
>those qemuSecurity*() wrappers do.
>
>To help us ensure correctness (from this POV), we have a
>syntax-check rule that forbids any occurrence of
>"virSecurityManager" string under src/qemu/ (except for
>qemu_security of course).
>
>But with if we want to remove virSecurityManagerPtr type, then we
>have to allow "virSecurityManager *". Therefore, change the rule
>so that no call of a function with "virSecurityManager" prefix is
>allowed. And also change the name to better reflect what is going
>on.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> build-aux/syntax-check.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210312/07a424f3/attachment-0001.sig>


More information about the libvir-list mailing list