[libvirt PATCH v3 06/10] ci: Implement 'shell' helper action

Andrea Bolognani abologna at redhat.com
Mon Mar 15 17:58:17 UTC 2021


On Mon, 2021-03-15 at 14:24 +0100, Erik Skultety wrote:
> On Fri, Mar 12, 2021 at 06:28:18PM +0100, Andrea Bolognani wrote:
> > +        containerparser.add_argument(
> > +            "target",
> > +            help="build on target OS",
> 
> With the 'shell' action, not sure if "build" is the right word in that case,
> how about "perform action on target OS" -- since the "target" argument is
> shared among ['shell', 'build', 'test'].

Good catch! The word "build" was simply a leftover from development,
when I implemented (and documented) the "build" action first :)

I've made all the changes you suggested and pushed the series. Thanks
for your reviews!

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list