[PATCH 6/6] lib: Drop internal virXXXPtr typedefs

Michal Privoznik mprivozn at redhat.com
Tue Mar 16 14:05:36 UTC 2021


On 3/12/21 8:59 AM, Michal Privoznik wrote:
> On 3/11/21 7:47 PM, Daniel P. Berrangé wrote:
>> On Thu, Mar 11, 2021 at 06:54:20PM +0100, Michal Privoznik wrote:
>>> Historically, we declared pointer type to our types:
>>>
>>>    typedef struct _virXXX virXXX;
>>>    typedef virXXX *virXXXPtr;
>>>


> 
>>
>> Also dropping usage of the "Ptr" should be separate from dropping
>> the typedefs themselves as I think that'll make conflicts easier
>> to deal with.
> 
> Yeah, this makes sense. I'll split it.
> 

On a second thought, does it make sense? I don't think that somebody 
would want to backport just the rewrite without dropping the typedefs, 
or backport just the typedef drop without the rewrite. It's all or nothing.

Michal




More information about the libvir-list mailing list