[libvirt PATCH v2 5/6] ci: helper: Rewrite image listing to Python

Andrea Bolognani abologna at redhat.com
Wed Mar 17 11:09:14 UTC 2021


On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
> +ci-list-images: help

I'd just drop the target altogether. The entire Makefile is hopefully
going to disappear soon enough anyway, so I'd really rather not put
any additional work into it.

> +        print("Available x86 container images:\n")
> +        print("\t" + "\n\t".join(native))

No tabs, please. Just use four spaces.

> +        if cross:
> +            print()
> +            print("Available cross-compiler container images:\n")
> +            print("\t" + "\n\t".join(cross))

Same here.

With these small tweaks applied,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list