[libvirt PATCH 10/38] domain_conf: Use virXMLProp(OnOff|YesNo) in virDomainActualNetDefParseXML

Tim Wiederhake twiederh at redhat.com
Thu Mar 18 08:00:49 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/conf/domain_conf.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 8dbf371e81..b8dfc77cfc 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -10474,8 +10474,8 @@ virDomainActualNetDefParseXML(xmlNodePtr node,
     g_autofree char *type = NULL;
     g_autofree char *mode = NULL;
     g_autofree char *addrtype = NULL;
-    g_autofree char *trustGuestRxFilters = NULL;
     g_autofree char *macTableManager = NULL;
+    virTristateBool trustGuestRxFilters = VIR_TRISTATE_BOOL_ABSENT;
 
     actual = g_new0(virDomainActualNetDef, 1);
 
@@ -10502,15 +10502,9 @@ virDomainActualNetDefParseXML(xmlNodePtr node,
         goto error;
     }
 
-    trustGuestRxFilters = virXMLPropString(node, "trustGuestRxFilters");
-    if (trustGuestRxFilters &&
-        ((actual->trustGuestRxFilters
-          = virTristateBoolTypeFromString(trustGuestRxFilters)) <= 0)) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                       _("unknown trustGuestRxFilters value '%s'"),
-                       trustGuestRxFilters);
+    if (virXMLPropYesNo(node, "trustGuestRxFilters", &trustGuestRxFilters) < 0)
         goto error;
-    }
+    actual->trustGuestRxFilters = trustGuestRxFilters;
 
     virtPortNode = virXPathNode("./virtualport", ctxt);
     if (virtPortNode) {
-- 
2.26.2




More information about the libvir-list mailing list