[PATCH] virxml: Fix possible memory leak in virXMLNodeContentString()

Michal Privoznik mprivozn at redhat.com
Thu Mar 18 12:05:57 UTC 2021


On 3/17/21 6:01 PM, Kristina Hanicova wrote:
> Previously, if xml node passed to the virXMLNodeContentString()
> was not of type XML_ELEMENT_NODE, @ret could have caused a memory
> leak because xmlNodeGetContent() works for other types of nodes
> as well.
> 
> Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
> ---
>   src/util/virxml.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Nice catch! Pushed.

Michal




More information about the libvir-list mailing list