[libvirt PATCH v2 28/51] domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseLog

Tim Wiederhake twiederh at redhat.com
Fri Mar 19 13:40:42 UTC 2021


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/conf/domain_conf.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fd7613a479..619a4306f6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -11813,17 +11813,10 @@ static int
 virDomainChrSourceDefParseLog(virDomainChrSourceDefPtr def,
                               xmlNodePtr log)
 {
-    g_autofree char *append = NULL;
-
     def->logfile = virXMLPropString(log, "file");
 
-    if ((append = virXMLPropString(log, "append")) &&
-        (def->logappend = virTristateSwitchTypeFromString(append)) <= 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR,
-                       _("Invalid append attribute value '%s'"),
-                       append);
+    if (virXMLPropTristateSwitch(log, "append", false, &def->logappend) < 0)
         return -1;
-    }
 
     return 0;
 }
-- 
2.26.2




More information about the libvir-list mailing list