[libvirt PATCH 0/7] Change reallocation APIs to return void

[Michal Privoznik]

On 3/20/21 12:36 AM, Jiri Denemark wrote:
> They can never return anything but zero anyway.
> 
> Jiri Denemark (7):
>    util: Drop G_GNUC_WARN_UNUSED_RESULT from reallocation APIs
>    Do not check return value of VIR_RESIZE_N
>    util: Make virResizeN return void
>    Do not check return value of VIR_EXPAND_N
>    util: Make virExpandN return void
>    Do not check return value of VIR_REALLOC_N
>    util: Make virReallocN return void
> 
>   src/access/viraccessdriverstack.c             |  3 +-
>   src/bhyve/bhyve_capabilities.c                |  5 +--
>   src/bhyve/bhyve_parse_command.c               | 19 +++-----
>   src/conf/backup_conf.c                        |  3 +-
>   src/conf/capabilities.c                       | 43 +++++-------------
>   src/conf/cpu_conf.c                           | 11 +----
>   src/conf/domain_addr.c                        |  6 +--
>   src/conf/domain_capabilities.c                |  5 +--
>   src/conf/domain_conf.c                        | 14 +++---
>   src/conf/nwfilter_conf.c                      |  6 +--
>   src/conf/nwfilter_params.c                    |  8 +---
>   src/conf/storage_conf.c                       |  3 +-
>   src/conf/virinterfaceobj.c                    |  2 +-
>   src/conf/virnetworkobj.c                      |  4 +-
>   src/conf/virnodedeviceobj.c                   |  2 +-
>   src/conf/virsecretobj.c                       |  2 +-
>   src/conf/virstorageobj.c                      |  2 +-
>   src/esx/esx_driver.c                          |  7 +--
>   src/esx/esx_stream.c                          |  3 +-
>   src/hyperv/hyperv_driver.c                    |  3 +-
>   src/hyperv/hyperv_wmi.c                       |  3 +-
>   src/hypervisor/domain_driver.c                |  3 +-
>   src/hypervisor/virclosecallbacks.c            |  2 +-
>   src/interface/interface_backend_netcf.c       |  2 +-
>   src/interface/interface_backend_udev.c        |  2 +-
>   src/libxl/libxl_capabilities.c                |  3 +-
>   src/libxl/libxl_conf.c                        | 23 ++++------
>   src/libxl/libxl_driver.c                      | 15 +++----
>   src/libxl/xen_common.c                        |  6 +--
>   src/locking/lock_driver_lockd.c               |  4 +-
>   src/lxc/lxc_controller.c                      | 18 ++------
>   src/lxc/lxc_native.c                          | 33 +++++---------
>   src/qemu/qemu_agent.c                         | 11 ++---
>   src/qemu/qemu_capabilities.c                  |  3 +-
>   src/qemu/qemu_conf.c                          |  6 +--
>   src/qemu/qemu_domain.c                        | 13 +++---
>   src/qemu/qemu_firmware.c                      |  5 +--
>   src/qemu/qemu_hotplug.c                       | 36 +++++----------
>   src/qemu/qemu_monitor.c                       |  4 +-
>   src/qemu/qemu_monitor_json.c                  | 12 +----
>   src/qemu/qemu_process.c                       | 25 +----------
>   src/rpc/virnetclient.c                        | 19 ++------
>   src/rpc/virnetdaemon.c                        |  3 +-
>   src/rpc/virnetlibsshsession.c                 |  8 +---
>   src/rpc/virnetmessage.c                       | 12 ++---
>   src/rpc/virnetserver.c                        | 19 ++------
>   src/rpc/virnetsocket.c                        |  3 +-
>   src/rpc/virnetsshsession.c                    |  8 +---
>   src/storage/storage_backend_disk.c            |  4 +-
>   src/storage/storage_backend_logical.c         |  3 +-
>   src/storage/storage_backend_rbd.c             |  6 +--
>   .../storage_file_backend_gluster.c            |  3 +-
>   .../storage_source_backingstore.c             |  3 +-
>   src/util/viralloc.c                           | 44 +++++++++----------
>   src/util/viralloc.h                           | 18 ++++----
>   src/util/virarptable.c                        |  3 +-
>   src/util/virbitmap.c                          |  5 +--
>   src/util/vircommand.c                         | 23 +++++-----
>   src/util/virdnsmasq.c                         | 13 ++----
>   src/util/virfile.c                            | 22 +++-------
>   src/util/virfirewall.c                        |  8 +---
>   src/util/virjson.c                            | 13 ++----
>   src/util/virlockspace.c                       |  7 +--
>   src/util/virnetlink.c                         |  7 ++-
>   src/util/virnuma.c                            | 14 +++---
>   src/util/virprocess.c                         | 17 +------
>   src/util/virresctrl.c                         | 42 +++++++-----------
>   src/util/virstring.c                          |  9 ++--
>   src/util/virsysinfo.c                         | 37 ++++------------
>   src/util/virsystemd.c                         |  3 +-
>   src/util/virthreadpool.c                      |  3 +-
>   src/util/virtypedparam-public.c               | 24 ++++------
>   src/util/virtypedparam.c                      |  9 ++--
>   src/util/viruri.c                             |  8 +---
>   src/util/virutil.c                            | 14 ++----
>   src/vbox/vbox_common.c                        |  4 +-
>   src/vbox/vbox_snapshot_conf.c                 | 29 +++---------
>   tests/domaincapstest.c                        |  8 +---
>   tests/qemublocktest.c                         |  3 +-
>   tests/qemudomaincheckpointxml2xmltest.c       |  3 +-
>   tests/qemumonitortestutils.c                  | 12 ++---
>   tests/securityselinuxlabeltest.c              |  7 +--
>   tests/viralloctest.c                          | 15 +++----
>   tools/virsh-console.c                         | 22 ++++------
>   tools/virsh-domain.c                          | 27 +++---------
>   tools/virt-login-shell-helper.c               |  3 +-
>   tools/vsh.c                                   |  6 +--
>   87 files changed, 284 insertions(+), 669 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal