[PATCH 1/1] domain_cgroup.c: update domain after setting blkio.weight

Ján Tomko jtomko at redhat.com
Tue Mar 23 10:03:10 UTC 2021


On a Monday in 2021, Daniel Henrique Barboza wrote:
>Commit ac87d3520ad5 consolidated common cgroup code between the QEMU and
>lxc drivers in domain_cgroup.c. In this process, in
>virDomainCgroupSetupDomainBlkioParameters(), a call to
>virCgroupGetBlkioWeight() went missing.
>
>The result is that 'virsh blkiotune' is setting the blkio.weight for the
>guest in the host cgroup, but not on the domain XML, because
>virCgroupGetBlkioWeight() is also used to write the blkio.weight value
>in the domain object.
>
>Fix it by adding the virCgroupGetBlkioWeight() call in the
>virDomainCgroupSetupDomainBlkioParameters() helper.
>
>Fixes: 5493217b940ee9ea72b581270adb3ab9ba245148

fatal: bad object 5493217b940ee9ea72b581270adb3ab9ba245148

>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941407
>Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
>---
> src/hypervisor/domain_cgroup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210323/c63a3cef/attachment-0001.sig>


More information about the libvir-list mailing list