[PATCH v2] qemu: don't raise error upon interface update without <frames/> for <rx/> in coalesce

Martin Kletzander mkletzan at redhat.com
Tue Mar 23 15:28:48 UTC 2021


On Wed, Mar 10, 2021 at 06:01:17PM +0100, Kristina Hanicova wrote:
>With this, incomplete XML without <frames/> for <rx/> in coalesce
>won't raise error as before. It will leave the coalesce parameter
>empty, thanks to passing it as a parameter and return an integer
>to indicate error state - previously it returned pointer (or NULL
>for both error and incomplete XML).
>I also added a test case to test this functionality in the
>qemuxml2xmltest.
>
>The code went through some refactoring:
>* change of a condition
>* addition of a parameter
>* change of order, that allowed removal of VIR_FREE
>* removal of redundant labels and variables
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1535930
>Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
>---

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

And pushed now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210323/41c46e98/attachment-0001.sig>


More information about the libvir-list mailing list