[PATCH v2 0/2] Fix calling of virNetworkUpdate() driver callback

Martin Kletzander mkletzan at redhat.com
Wed Mar 24 16:02:57 UTC 2021


On Tue, Mar 16, 2021 at 12:44:04PM +0100, Michal Privoznik wrote:
>v2 of:
>
>https://listman.redhat.com/archives/libvir-list/2021-March/msg00052.html
>
>I've pushed 1/2 from the v1 series (which just debug printed all
>arguments) which is unrelated to this problem.
>
>diff to v1:
>- Implemented different approach as suggested by Jano in his review of
>  v1. I must say I like it more.
>
>Michal Prívozník (2):
>  network: Implement virConnectSupportsFeature()
>  lib: Fix calling of virNetworkUpdate() driver callback

Terrifying, but makes sense.

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>
> src/esx/esx_driver.c                |  3 +++
> src/libvirt-network.c               | 24 ++++++++++++++++++++--
> src/libvirt_internal.h              |  5 +++++
> src/libxl/libxl_driver.c            |  1 +
> src/lxc/lxc_driver.c                |  1 +
> src/network/bridge_driver.c         | 32 +++++++++++++++++++++++++++++
> src/openvz/openvz_driver.c          |  1 +
> src/qemu/qemu_driver.c              |  1 +
> src/remote/remote_daemon_dispatch.c |  1 +
> src/test/test_driver.c              |  1 +
> 10 files changed, 68 insertions(+), 2 deletions(-)
>
>-- 
>2.26.2
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210324/daa9dd00/attachment-0001.sig>


More information about the libvir-list mailing list