[PATCH] qemu: virtiofs: support <sandbox mode='chroot'/>

[Cole Robinson]

On 3/26/21 11:53 AM, Peter Krempa wrote:
> On Fri, Mar 26, 2021 at 11:37:48 -0400, Cole Robinson wrote:
>> Add a new XML element
>>
>> <filesystem>
>>   <binary>
>>     <sandbox mode='chroot|namespace'/>
>>   </binary>
>> </filesystem>
>>
>> Which maps to `virtiofsd -o sandbox=chroot|namespace`, which was added
>> in qemu 5.2.0:
>>
>> https://git.qemu.org/?p=qemu.git;a=commit;h=06844584b62a43384642f7243b0fc01c9fff0fc7
>>
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> ---
>>  docs/formatdomain.rst                         |  4 ++++
>>  docs/schemas/domaincommon.rng                 | 12 ++++++++++
>>  src/conf/domain_conf.c                        | 23 +++++++++++++++++++
>>  src/conf/domain_conf.h                        | 10 ++++++++
>>  src/libvirt_private.syms                      |  1 +
>>  src/qemu/qemu_virtiofs.c                      |  2 ++
>>  .../vhost-user-fs-fd-memory.xml               |  1 +
>>  7 files changed, 53 insertions(+)
> 
> Please split the commit as it's usual for libvirt patches.
> 

Okay, fixed in v2. I addressed the docs and validation piece in v2 too

> Also a test case modifying any of the .args files in qemuxml2argv test
> is missing.
> 

This option affects the virtiofsd command line only, so it won't be
reflected in .args files

Thanks,
Cole