[PATCH] qemu_driver: Acquire MODIFY job in qemuDomainStartDirtyRateCalc()

Jiri Denemark jdenemar at redhat.com
Mon Mar 29 15:33:21 UTC 2021


On Mon, Mar 29, 2021 at 14:49:36 +0200, Michal Privoznik wrote:
> This API talks to QEMU and changes its internal state. Therefore,
> it should acquire QEMU_JOB_MODIFY instead of QEMU_JOB_QUERY.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 69dc704a44..af015f0625 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -20425,7 +20425,7 @@ qemuDomainStartDirtyRateCalc(virDomainPtr dom,
>      if (virDomainStartDirtyRateCalcEnsureACL(dom->conn, vm->def) < 0)
>          goto cleanup;
>  
> -    if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
> +    if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0)
>          goto cleanup;
>  
>      if (!virDomainObjIsActive(vm)) {

Reviewed-by: Jiri Denemark <jdenemar at redhat.com>




More information about the libvir-list mailing list