[PATCH 0/6] qemu: Allow control of deprecation behaviour

Martin Kletzander mkletzan at redhat.com
Wed Mar 31 22:36:52 UTC 2021


On Fri, Mar 19, 2021 at 07:33:48PM +0100, Peter Krempa wrote:
>For debugging purposes it's very useful to disable all deprecated
>commands and fields in qemu. This series implements a qemu.conf knob and
>a qemu namespace element to control this.
>
>The implementation tries to be very conservative to allow downgrades of
>qemu and such without breaking the startup of the VM.
>
>The intention is that developers and CI deployments use the 'crash'
>option to catch any unexpected qemu disappearance.
>
>Note that this applies on top of my series for -object QAPIfication.
>
>Based on Markus' -compat series which was now merged to upstream qemu.
>
>Peter Krempa (6):
>  docs/drvqemu: Convert to RST

I wanted to review the output of this first patch side-by-side so that I
do not have to go through all the markup hell.  But when I tried looking
for the artefacts from any possible pipeline this could have run through
I was greeted with a "get off my lawn" message.  So if you are okay with
me just skimming through the first patch (after reviewing the rest of da
patch series), then with the mentioned fixes, this is for you (xkcd#276)

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>  qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED
>  qemu: conf: Add 'deprecation_behavior' setting to qemu.conf
>  qemuxml2xmltest: Enable 'qemu-ns' case
>  qemu: Add per-VM control of deprecation behavior
>  qemu: command: Handle formatting of '-compat' options
>
> docs/drvqemu.html.in                          | 743 ------------------
> docs/drvqemu.rst                              | 636 +++++++++++++++
> docs/formatdomain.rst                         |   2 +-
> docs/manpages/virt-qemu-run.rst               |   2 +-
> docs/meson.build                              |   2 +-
> docs/schemas/domaincommon.rng                 |  16 +
> src/qemu/libvirtd_qemu.aug                    |   1 +
> src/qemu/qemu.conf                            |  31 +
> src/qemu/qemu_capabilities.c                  |   8 +
> src/qemu/qemu_capabilities.h                  |   1 +
> src/qemu/qemu_command.c                       |  80 ++
> src/qemu/qemu_conf.c                          |   4 +
> src/qemu/qemu_conf.h                          |   2 +
> src/qemu/qemu_domain.c                        |  10 +-
> src/qemu/qemu_domain.h                        |   5 +
> src/qemu/test_libvirtd_qemu.aug.in            |   1 +
> .../caps_6.0.0.x86_64.xml                     |   1 +
> .../qemu-ns.x86_64-latest.args                |   1 +
> tests/qemuxml2argvdata/qemu-ns.xml            |   1 +
> .../qemu-ns.x86_64-latest.xml                 |  52 ++
> tests/qemuxml2xmltest.c                       |   1 +
> 21 files changed, 853 insertions(+), 747 deletions(-)
> delete mode 100644 docs/drvqemu.html.in
> create mode 100644 docs/drvqemu.rst
> create mode 100644 tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml
>
>-- 
>2.29.2
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210401/0b0634ed/attachment-0001.sig>


More information about the libvir-list mailing list