[PATCH] XML validate that 'ramfb' has no address

Kristina Hanicova khanicov at redhat.com
Fri Mar 5 12:01:21 UTC 2021


With this, XML fails if config video type 'ramfb' contains
address, since address is not supported for 'ramfb' video
devices. Previously it didn't raise error.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1891416
Signed-off-by: Kristina Hanicova <khanicov at redhat.com>
---
 src/conf/domain_validate.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index b4e09e21fe..c9c677ddf5 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -151,6 +151,14 @@ virDomainVideoDefValidate(const virDomainVideoDef *video,
         }
     }
 
+    if (video->type == VIR_DOMAIN_VIDEO_TYPE_RAMFB) {
+        if (video->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+                           _("address not supported for video type ramfb"));
+            return -1;
+        }
+    }
+
     return 0;
 }
 
-- 
2.29.2




More information about the libvir-list mailing list