[libvirt PATCH v2 4/6] ci: Introduce a util module

[Erik Skultety]

On Wed, Mar 17, 2021 at 12:02:31PM +0100, Andrea Bolognani wrote:
> On Tue, 2021-03-16 at 18:32 +0100, Erik Skultety wrote:
> > +import urllib.request as urllibrequest
> > +import urllib.parse as urllibparse
> 
> The aliasing doesn't look like it serves a real purpose here, as it
> only saves a single character... I'd import, and use, urrlib.request
> and urllib.parse directly.

Okay, I can do that, the point was not to import urllib as is, because that
may not work reliably - for some reason Python refuses to import giant modules
and will report an error that it could not find a symbol, so you have to import
a submodule instead.

> 
> > +    apistr = str(api_version)
> > +    project_uri = f"{gitlab_uri}/api/v{apistr}/projects/{namespace_urlenc}"
> 
> Can't you use api_version without explicitly casting/converting it to
> a string here? It seems to work.

I have to re-try, but at some point Python was complaining about it being an
int.

> 
> With these two nits addressed,
> 
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization
>