[PATCH 2/2] virDomainVideoDriverDefParseXML: Allow zero value for @vgaconf

Michal Privoznik mprivozn at redhat.com
Wed May 5 14:15:45 UTC 2021


It was always allowed, but in a very unusual and weird way. Just
look at the original commit that introduced it (78fc843c7b5).
Also, we document that "io" value is accepted (which translates
to VIR_DOMAIN_VIDEO_VGACONF_IO with value of zero).

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3319cb49cf..77105e6a07 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14326,7 +14326,7 @@ virDomainVideoDriverDefParseXML(xmlNodePtr node,
 
     if (virXMLPropEnum(driver, "vgaconf",
                        virDomainVideoVGAConfTypeFromString,
-                       VIR_XML_PROP_NONZERO, &def->vgaconf) < 0)
+                       VIR_XML_PROP_NONE, &def->vgaconf) < 0)
         return NULL;
 
     return g_steal_pointer(&def);
-- 
2.26.3




More information about the libvir-list mailing list