[PATCH 04/17] virDomainDiskDefDriverParseXML: Fix usage of virXMLPropUInt

Peter Krempa pkrempa at redhat.com
Thu May 6 15:30:56 UTC 2021


VIR_XML_PROP_NONE has value of 0 so it's pointless to include it in an
binary-or expression.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/domain_conf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a2dd7d649f..baf5d31606 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8923,9 +8923,7 @@ virDomainDiskDefDriverParseXML(virDomainDiskDef *def,
                        VIR_XML_PROP_NONZERO, &def->discard) < 0)
         return -1;

-    if (virXMLPropUInt(cur, "iothread", 10,
-                       VIR_XML_PROP_NONE | VIR_XML_PROP_NONZERO,
-                       &def->iothread) < 0)
+    if (virXMLPropUInt(cur, "iothread", 10, VIR_XML_PROP_NONZERO, &def->iothread) < 0)
         return -1;

     if ((tmp = virXMLPropString(cur, "type"))) {
-- 
2.30.2




More information about the libvir-list mailing list