[PATCH 14/17] virDomainVideoDefParseXML: Fix parsing of 'backend'

Peter Krempa pkrempa at redhat.com
Thu May 6 15:31:06 UTC 2021


Commit 8391cfbc2dbc converted the code to use virXMLPropEnum unfaithfully
ommitting the check where 'backend' must be non-zero when parsed from the
user.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index d36ff536f4..bddc5eee26 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -14257,7 +14257,7 @@ virDomainVideoDefParseXML(virDomainXMLOption *xmlopt,
     if ((driver = virXPathNode("./driver", ctxt))) {
         if (virXMLPropEnum(driver, "name",
                            virDomainVideoBackendTypeFromString,
-                           VIR_XML_PROP_NONE, &def->backend) < 0)
+                           VIR_XML_PROP_NONZERO, &def->backend) < 0)
             return NULL;
         if (virDomainVirtioOptionsParseXML(driver, &def->virtio) < 0)
             return NULL;
-- 
2.30.2




More information about the libvir-list mailing list