[PATCH 2/2] rpm: Drop unnecessary libiscsi runtime dependency

[Neal Gompa]

On Mon, Jan 11, 2021 at 10:52 AM Andrea Bolognani <abologna at redhat.com> wrote:
>
> On Thu, 2021-01-07 at 13:48 -0500, Neal Gompa wrote:
> > On Thu, Jan 7, 2021 at 12:38 PM Jiri Denemark <jdenemar at redhat.com> wrote:
> > > On Thu, Jan 07, 2021 at 09:58:09 -0500, Neal Gompa wrote:
> > > > +++ b/libvirt.spec.in
> > > > @@ -614,7 +614,6 @@ volumes using the host iscsi stack.
> > > >  Summary: Storage driver plugin for iscsi-direct
> > > >  Requires: libvirt-daemon-driver-storage-core = %{version}-%{release}
> > > >  Requires: libvirt-libs = %{version}-%{release}
> > > > -Requires: libiscsi
> > >
> > > The explicit dependency was added by Andrea 2.5 years ago, perhaps he
> > > had reasons to do so. Any comments Andrea?
> >
> > It most likely dates back to when Fedora had two providers of libiscsi
> > sharing the same soname. That situation no longer exists today. Other
> > distributions also don't have that issue.
>
> I didn't offer much in the way of explanation for the change in
>
>   commit fe5b35c6b29dc952babf4436ccba83c4a0ffa82e
>   Author: Andrea Bolognani <abologna at redhat.com>
>   Date:   Tue Aug 14 14:31:35 2018 +0200
>
>     spec: Enable the iscsi-direct storage driver conditionally
>
>     Most distributions we build RPMs on don't ship a
>     recent enough version of libiscsi, so we can't enable
>     the driver unconditionally. Add an explicit dependency
>     on the runtime package while at it.
>
>     Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>     Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
>
> so I can only guess that I was mistakenly thinking the runtime
> dependency would not be added automatically.
>
> Under the assumption that Neal has already verified the set of
> runtime dependencies is exactly the same, on all RPM-based targets,
> before and after this patch has been applied,
>
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
>
> --
> Andrea Bolognani / Red Hat / Virtualization
>

So apparently this wasn't actually pushed yet... Can we get this pushed now?

-- 
真実はいつも一つ！/ Always, there's only one truth!