[PATCH] virsh: Fix logic wrt to --current flag in cmdSetmem

Ján Tomko jtomko at jtomko.net
Tue May 18 13:02:55 UTC 2021

On a Tuesday in 2021, Michal Privoznik wrote:
>In my commit of v7.1.0-rc1~376 I've simplified the logic of
>handling @flags. My assumption back then was that calling
>virDomainSetMemory() is equivalent to
>virDomainSetMemoryFlags(flags = 0). But that is not the case,
>because it is equivalent to virDomainSetMemoryFlags(flags =
>VIR_DOMAIN_AFFECT_LIVE). Fix the condition that calls the old
>Fixes: b5e267e8c59a257652f88d034cb1e0ce1ed4b58a

before that commit, if the user did not specify any of:
   config, live, current
we used the old API.

After this change, the new API will be used for those cases.


>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1961118
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> tools/virsh-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210518/19480576/attachment-0001.sig>

More information about the libvir-list mailing list