[PATCH 3/4] virsh: Expose new win-dmp dump format

Michal Privoznik mprivozn at redhat.com
Thu May 20 13:49:54 UTC 2021

In previous commit the virDomainCoreDumpWithFormat() API gained
new format. Expose it.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
 docs/manpages/virsh.rst | 5 +++--
 tools/virsh-domain.c    | 2 ++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index ad91cd6356..87668f2b9a 100644
--- a/docs/manpages/virsh.rst
+++ b/docs/manpages/virsh.rst
@@ -2554,9 +2554,10 @@ If *--memory-only* is specified, the file is elf file, and will only
 include domain's memory and cpu common register value. It is very
 useful if the domain uses host devices directly.
 *--format* *string* is used to specify the format of 'memory-only'
-dump, and *string* can be one of them: elf, kdump-zlib(kdump-compressed
+dump, and *string* can be one of: elf, kdump-zlib(kdump-compressed
 format with zlib-compressed), kdump-lzo(kdump-compressed format with
-lzo-compressed), kdump-snappy(kdump-compressed format with snappy-compressed).
+lzo-compressed), kdump-snappy(kdump-compressed format with snappy-compressed),
+win-dmp(Windows full crashdump format).
 The progress may be monitored using ``domjobinfo`` virsh command and canceled
 with ``domjobabort`` command (sent by another virsh instance). Another option
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 5a5215ab4c..dc9712bce5 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -5463,6 +5463,8 @@ doDump(void *opaque)
                 dumpformat = VIR_DOMAIN_CORE_DUMP_FORMAT_KDUMP_SNAPPY;
             } else if (STREQ(format, "elf")) {
                 dumpformat = VIR_DOMAIN_CORE_DUMP_FORMAT_RAW;
+            } else if (STREQ(format, "win-dmp")) {
+                dumpformat = VIR_DOMAIN_CORE_DUMP_FORMAT_WIN_DMP;
             } else {
                 vshError(ctl, _("format '%s' is not supported, expecting "
                                 "'kdump-zlib', 'kdump-lzo', 'kdump-snappy' "

More information about the libvir-list mailing list