[PATCH v1] libxl: remove libxl_domain_build_info_init from libxlMakeDomBuildInfo

Jim Fehlig jfehlig at suse.com
Fri May 21 17:02:39 UTC 2021


On 5/20/21 5:26 AM, Olaf Hering wrote:
> The used libxl_domain_build_info, which is contained in
> libxl_domain_config, is owned and already initialized by the caller.
> 
> Signed-off-by: Olaf Hering <olaf at aepfle.de>
> ---
>   src/libxl/libxl_conf.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Jim Fehlig <jfehlig at suse.com

> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 1fd0322b6a..3598ca395d 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -346,8 +346,6 @@ libxlMakeDomBuildInfo(virDomainDef *def,
>       size_t i;
>       size_t nusbdevice = 0;
>   
> -    libxl_domain_build_info_init(b_info);
> -
>       if (hvm) {
>           libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_HVM);
>       } else if (pvh) {
> 




More information about the libvir-list mailing list